Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Fix timeline ui #2329

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[frontend] Fix timeline ui #2329

merged 1 commit into from
Jan 30, 2025

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Jan 30, 2025 •
edited
Loading

Proposed changes

  • Filter out disabled inject from timeline

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Jan 30, 2025
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Jan 30, 2025
@savacano28 savacano28 marked this pull request as ready for review January 30, 2025 14:48
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.79%. Comparing base (1087647) to head (4880c85).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2329   +/-   ##
=========================================
  Coverage     32.79%   32.79%           
  Complexity     1519     1519           
=========================================
  Files           585      585           
  Lines         18016    18016           
  Branches       1157     1157           
=========================================
  Hits           5909     5909           
  Misses        11843    11843           
  Partials        264      264

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 merged commit 5db2059 into master Jan 30, 2025
7 checks passed
@savacano28 savacano28 deleted the bugfix/2294-1 branch February 4, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumejparis guillaumejparis guillaumejparis approved these changes

Assignees

@savacano28 savacano28

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injects that have been removed are still visible in the timeline
2 participants
@savacano28 @guillaumejparis